✨ [Frontend] Workspaces & Folders: Merge Workspace header and Folder breadcrumbs #6414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
changed the title
odeimaiz
changed the title
odeimaiz
requested review from
GitHK,
calys,
matusdrobuliak66,
pcrespov and
sanderegg
|
GitHK
approved these changes
Sep 23, 2024
ignapas
approved these changes
Sep 23, 2024
jsaq007
pushed a commit
to jsaq007/osparc-simcore
that referenced
this pull request
Sep 25, 2024
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Oct 2, 2024
16 tasks
This was referenced Oct 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
One of the coming feature requests will make the Search bar search projects across all workspaces and folders.
Therefore, the Search bar needs to go over Workspace header. And since now the Workspace header and Folder breadcrumbs were very close from each other, it was decided to merge them and show the breadcrumbs right after the workspace title. All the functionality to change context were kept.
Before:
After:
Related issue/s
related to #6405
related to ITISFoundation/osparc-issues#716
How to test
Dev-ops checklist